Changes to make standalone run also from within a CMSSW area #36

VourMa · 2024-06-08T02:37:58Z

When we are within a CMSSW area, we would like the data files to be picked up from the CMSSW_SEARCH_PATH. This was not possible with the current setup.sh, as it was resetting the search path. This behavior is now modified, partially according to #30 (comment), so it may be a controversial change and feedback is welcome.
That also means that we want to change the order with which we check the potential directories in which the data files may reside, and this is also taken care of in this PR.

Once we agree on the changes, I can upload a README with instructions on how to test the standalone both within and without a CMSSW area.

VourMa · 2024-06-10T16:20:28Z

@ariostas Please let me know what you think of this one. I would like to decide on whether this looks fine or not before writing the instructions for how to test PRs in CMSSW locally.

RecoTracker/LSTCore/src/alpaka/LSTESData.dev.cc

ariostas · 2024-06-10T16:32:17Z

@VourMa The changes look good to me. It's up to you whether we should remove LST_BASE now or just do it later.

ariostas · 2024-06-10T16:34:14Z

It shouldn't break the CI, but just to make sure.

/run all

github-actions · 2024-06-10T16:53:45Z

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     44.1    325.1    123.1     47.6     95.5    503.5    132.4    158.1    100.1      1.8    1531.4     983.9+/- 256.0     415.1   explicit_cache[s=4] (target branch)
   avg     44.0    323.3    121.7     48.0     95.9    505.7    133.2    156.8     99.4      1.9    1529.7     980.0+/- 257.3     416.5   explicit_cache[s=4] (this PR)

slava77 · 2024-06-10T17:03:39Z

I'm not sure this should be just in the devel branch; the updates are supposedly in the context of the cms-sw PR to get things run in standalone.

However, since the CI runs already, I guess this change can be applied later (no need to add this to the batch2 branch as well).
Is my understanding correct?

VourMa · 2024-06-10T18:45:48Z

It's up to you whether we should remove LST_BASE now

I can remove it now to be done with it. I will add one more commit to this PR a bit later today.

I'm not sure this should be just in the devel branch; the updates are supposedly in the context of the cms-sw PR to get things run in standalone.

This can definitely go in the batch 2 as well, and maybe it finalizes the "Modifications to the standalone scripts" to-do that we have set in the cms-sw PR description, although I am not sure of the best way to do it. Let me know what you prefer and I will do it.

github-actions · 2024-06-10T18:46:02Z

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

The full set of validation and comparison plots can be found here.

RecoTracker/LSTCore/standalone/setup.sh

VourMa · 2024-06-11T00:07:08Z

@slava77 @ariostas If there are no more comments, please approve the PR but do not merge it yet - I would like to push the README with the instructions.

VourMa · 2024-06-11T20:56:54Z

I think this is ready to be merged now. People can test the README instructions to check whether they work for them.

slava77 · 2024-06-11T22:43:38Z

RecoTracker/LSTCore/standalone/README.md

+export PATH=/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/external/el8_amd64_gcc12/bin:$PATH
+export LD_LIBRARY_PATH=/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/biglib/el8_amd64_gcc12:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/lib/el8_amd64_gcc12:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/external/el8_amd64_gcc12/lib:/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib64:/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib:$LD_LIBRARY_PATH


I don't quite follow how this can be a part of when CVMFS is not available; perhaps the text from below they can point to local directories can be added here instead?

Shouldn't only external/gcc and external/cuda be necessary instead of the cmssw path?

are the biglib and cmssw/lib really needed; I'd expect only gcc and cuda are needed

Yeah, I think that the extra library paths was because the gcc in cvmfs has some preconfigured stuff that depends on the other libraries, but in principle one would just need vanilla gcc and nvcc.

RecoTracker/LSTCore/standalone/README.md

VourMa · 2024-06-12T08:41:14Z

General reply on the comments for the README: both are valid, and especially for the first one, I don't know how it worked before - this was just (blindly) keeping the relevant README section from what already existed. It is clear that it needs to be updated. Having said that, I am not willing to come up with all the details for the CVMFS-less configuration at this stage. My proposal is to comment out that part of the README and come back to it if needed in the future.

RecoTracker/LSTCore/standalone/README.md

ariostas · 2024-06-13T04:26:14Z

RecoTracker/LSTCore/standalone/README.md

+Currently, the data files for LST need to be copied manually. This is done by running:
+
+```bash
+git clone [email protected]:cms-data/RecoTracker-LSTCore.git data


It's probably worth mentioning where this data directory should reside. It's not clear whether it's in standalone or LSTCore.

You are right, and in fact I had the directory wrong in one case. I now fixed that and added an explicit mention of the directory where the data files should end up.

Looking at the setup.sh, after it's called the $CMSSW_SEARCH_PATH will already be set.
So, the same git clone [email protected]:cms-data/RecoTracker-LSTCore.git $CMSSW_BASE/external/$SCRAM_ARCH/data/RecoTracker/LSTCore/data should work (note that cd in and out of the target directory is not really necessary)

oh, nevermind; that search path will not include the local CMSSW checkout

slava77 · 2024-06-13T21:28:29Z

/run all

github-actions · 2024-06-13T21:35:20Z

There was a problem while building and running with CMSSW. The logs can be found here.

github-actions · 2024-06-13T21:42:12Z

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     43.9    323.9    122.7     48.2     95.9    500.3    134.0    156.8    105.8      1.8    1533.2     989.0+/- 259.8     418.0   explicit_cache[s=4] (target branch)
   avg     43.7    325.7    123.4     50.2     97.4    499.9    133.9    158.3    106.7      1.6    1541.0     997.4+/- 263.0     420.8   explicit_cache[s=4] (this PR)

slava77 · 2024-06-13T21:44:19Z

There was a problem while building and running with CMSSW. The logs can be found here.

@ariostas is there a problem in the CI ?
It looks like it failed at checking out the baseline/reference part

ariostas · 2024-06-13T22:05:05Z

is there a problem in the CI ?

Sorry, there were two steps that should have been done in the opposite order. I'm re-running it now.

github-actions · 2024-06-13T23:35:20Z

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks

The full set of validation and comparison plots can be found here.

Changes to make standalone run also from within a CMSSW area

87dde1e

VourMa mentioned this pull request Jun 8, 2024

Make compilation flags for duplicate cleaning and triplet pLSs into runtime flags (TrackLooper PR#408 + cmssw PR#31) #37

Merged

VourMa requested review from slava77 and ariostas June 10, 2024 16:19

ariostas reviewed Jun 10, 2024

View reviewed changes

RecoTracker/LSTCore/src/alpaka/LSTESData.dev.cc Outdated Show resolved Hide resolved

slava77 reviewed Jun 10, 2024

View reviewed changes

RecoTracker/LSTCore/standalone/setup.sh Outdated Show resolved Hide resolved

Removal of LST_BASE and redudant setup lines

d1286b0

ariostas approved these changes Jun 11, 2024

View reviewed changes

Update standalone README.md with up-to-date instructions

f529d3f

slava77 reviewed Jun 11, 2024

View reviewed changes

RecoTracker/LSTCore/standalone/README.md Outdated Show resolved Hide resolved

Comment out the CVMFS-less setup (for now)

1d4b2aa

ariostas reviewed Jun 12, 2024

View reviewed changes

RecoTracker/LSTCore/standalone/README.md Outdated Show resolved Hide resolved

VourMa added 2 commits June 12, 2024 15:51

Delete deprecated code checks and format from README

96ec1b8

Include cloning of LST data files in README

2e0c608

ariostas reviewed Jun 13, 2024

View reviewed changes

VourMa added 2 commits June 13, 2024 12:24

Small updates to directories in the README

79fc142

Fix in README for fetching from correct repo

3b0dbda

slava77 merged commit 6c466f1 into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel Jun 14, 2024
3 checks passed

ariostas mentioned this pull request Nov 6, 2024

Devel changes that need to be rebased #117

Closed

15 tasks

ariostas mentioned this pull request Nov 20, 2024

Add occupancy branches + standalone improvements (rebase PR45, PR36, and PR55) #127

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to make standalone run also from within a CMSSW area #36

Changes to make standalone run also from within a CMSSW area #36

VourMa commented Jun 8, 2024

VourMa commented Jun 10, 2024

ariostas commented Jun 10, 2024

ariostas commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

slava77 commented Jun 10, 2024

VourMa commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

VourMa commented Jun 11, 2024

VourMa commented Jun 11, 2024

slava77 Jun 11, 2024

ariostas Jun 13, 2024

VourMa commented Jun 12, 2024

ariostas Jun 13, 2024

VourMa Jun 13, 2024

slava77 Jun 13, 2024

slava77 Jun 13, 2024

slava77 commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

slava77 commented Jun 13, 2024

ariostas commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

		export PATH=/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/external/el8_amd64_gcc12/bin:$PATH
		export LD_LIBRARY_PATH=/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/biglib/el8_amd64_gcc12:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/lib/el8_amd64_gcc12:/cvmfs/cms.cern.ch/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_0_pre3/external/el8_amd64_gcc12/lib:/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib64:/cvmfs/cms.cern.ch/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/lib:$LD_LIBRARY_PATH

Changes to make standalone run also from within a CMSSW area #36

Changes to make standalone run also from within a CMSSW area #36

Conversation

VourMa commented Jun 8, 2024

VourMa commented Jun 10, 2024

ariostas commented Jun 10, 2024

ariostas commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

slava77 commented Jun 10, 2024

VourMa commented Jun 10, 2024

github-actions bot commented Jun 10, 2024

VourMa commented Jun 11, 2024

VourMa commented Jun 11, 2024

slava77 Jun 11, 2024

Choose a reason for hiding this comment

ariostas Jun 13, 2024

Choose a reason for hiding this comment

VourMa commented Jun 12, 2024

ariostas Jun 13, 2024

Choose a reason for hiding this comment

VourMa Jun 13, 2024

Choose a reason for hiding this comment

slava77 Jun 13, 2024

Choose a reason for hiding this comment

slava77 Jun 13, 2024

Choose a reason for hiding this comment

slava77 commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

slava77 commented Jun 13, 2024

ariostas commented Jun 13, 2024

github-actions bot commented Jun 13, 2024